linux-kernel - Re: [PATCH AUTOSEL 6.2 51/53] devlink: health: Fix nla_nest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230227101300.33bbedd1@kernel.org>
Date:   Mon, 27 Feb 2023 10:13:00 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Moshe Shemesh <moshe@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        idosch@...dia.com, jacob.e.keller@...el.com,
        michal.wilczynski@...el.com, vikas.gupta@...adcom.com,
        shayd@...dia.com, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.2 51/53] devlink: health: Fix nla_nest_end in
 error flow

On Sun, 26 Feb 2023 09:44:43 -0500 Sasha Levin wrote:
> From: Moshe Shemesh <moshe@...dia.com>
> 
> [ Upstream commit bfd4e6a5dbbc12f77620602e764ac940ccb159de ]
> 
> devlink_nl_health_reporter_fill() error flow calls nla_nest_end(). Fix
> it to call nla_nest_cancel() instead.
> 
> Note the bug is harmless as genlmsg_cancel() cancel the entire message,
> so no fixes tag added.

Not really a fix as described, let's drop.