[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230227110047.224909ee@kernel.org>
Date: Mon, 27 Feb 2023 11:00:47 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Yanchao Yang (杨彦超)" <Yanchao.Yang@...iatek.com>
Cc: "Chris Feng (冯保林)" <Chris.Feng@...iatek.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"Mingliang Xu (徐明亮)" <mingliang.xu@...iatek.com>,
"Min Dong (董敏)" <min.dong@...iatek.com>,
"linuxwwan@...el.com" <linuxwwan@...el.com>,
"m.chetan.kumar@...el.com" <m.chetan.kumar@...el.com>,
"Liang Lu (吕亮)" <liang.lu@...iatek.com>,
"Haijun Liu (刘海军)" <haijun.liu@...iatek.com>,
"Haozhe Chang (常浩哲)" <Haozhe.Chang@...iatek.com>,
"Hua Yang (杨华)" <Hua.Yang@...iatek.com>,
"ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>,
"Xiayu Zhang (张夏宇)" <Xiayu.Zhang@...iatek.com>,
"loic.poulain@...aro.org" <loic.poulain@...aro.org>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"Ting Wang (王挺)" <ting.wang@...iatek.com>,
"johannes@...solutions.net" <johannes@...solutions.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"Aiden Wang ( 王咏麒)" <Aiden.Wang@...iatek.com>,
"Felix Chen ( 陈非)" <Felix.Chen@...iatek.com>,
"Lambert Wang ( 王伟)" <Lambert.Wang@...iatek.com>,
"davem@...emloft.net" <davem@...emloft.net>,
"Mingchuang Qiao (乔明闯)"
<Mingchuang.Qiao@...iatek.com>,
"Guohao Zhang (张国豪)" <Guohao.Zhang@...iatek.com>
Subject: Re: [PATCH net-next v3 01/10] net: wwan: tmi: Add PCIe core
On Mon, 27 Feb 2023 12:11:51 +0000 Yanchao Yang (杨彦超) wrote:
> On Fri, 2023-02-24 at 11:50 -0800, Jakub Kicinski wrote:
> > Relative paths work, right?
> >
> Okay. Change as follows, is that right?
> mtk_pci.h includes "mtk_dev.h",
> which is located in the parent folder.
> #include "../mtk_dev.h"
>
> mtk_fsm.c
> includes "mtk_reg.h", which is located in the child folder "pcie"
> #include "pcie/mtk_reg.h"
Yes, that's right.
> > > Any ideas or comments for this? Please help share it at your
> > > convenience.
> >
> > It's mandatory for new code.
> Okay. Change as follows, is that right?
> ......
> ret = mtk_ctrl_init(mdev);
> if (ret)
> goto free_fsm;
> ret = mtk_data_init(mdev)
> if (ret)
> goto free_ctrl_plane;
>
> return 0;
> free_ctrl_plane:
>
> mtk_ctrl_exit(mdev);
> free_fsm:
> mtk_fsm_exit(mdev);
> exit:
> return ret;
> }
That's right, thanks!
Powered by blists - more mailing lists