linux-kernel - Re: [PATCH] vc_screen: modify vcs_size() handling in vcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2023 12:06:47 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     George Kennedy <george.kennedy@...cle.com>
Cc:     jirislaby@...nel.org, gregkh@...uxfoundation.org,
        sfr@...b.auug.org.au, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        linux@...ssschuh.net, regressions@...ts.linux.dev
Subject: Re: [PATCH] vc_screen: modify vcs_size() handling in vcs_read()

On Mon, Feb 27, 2023 at 11:43 AM George Kennedy
<george.kennedy@...cle.com> wrote:
>
> Restore the vcs_size() handling in vcs_read() to what
> it had been in previous version.
>
> Suggested-by: Jiri Slaby <jirislaby@...nel.org>
> Signed-off-by: George Kennedy <george.kennedy@...cle.com>

Please also add a

   Fixes: 226fae124b2d ("vc_screen: move load of struct vc_data
pointer in vcs_read() to avoid UAF")

or whatever it was that broke this, so that we have that context to
what the "previous version" actually was.

               Linus