linux-kernel - Re: [PATCH] xen-netback: remove unused variables pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230227153503.3bc54eaf@kernel.org>
Date:   Mon, 27 Feb 2023 15:35:03 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tom Rix <trix@...hat.com>
Cc:     Juergen Gross <jgross@...e.com>, wei.liu@...nel.org, paul@....org,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen-netback: remove unused variables pending_idx and
 index

On Mon, 27 Feb 2023 09:29:30 +0100 Juergen Gross wrote:
> On 26.02.23 17:34, Tom Rix wrote:
> > building with gcc and W=1 reports
> > drivers/net/xen-netback/netback.c:886:21: error: variable
> >    ‘pending_idx’ set but not used [-Werror=unused-but-set-variable]
> >    886 |                 u16 pending_idx;
> >        |                     ^~~~~~~~~~~
> > 
> > pending_idx is not used so remove it.  Since index was only
> > used to set pending_idx, remove index as well.
> > 
> > Signed-off-by: Tom Rix <trix@...hat.com>  
> 
> Reviewed-by: Juergen Gross <jgross@...e.com>

Applied, thanks!