linux-kernel - Re: [PATCH] staging: rtl8712: Fixes the problem of irregular indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2023 07:45:11 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Shibo Li <zzutcyha@....com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Fixes the problem of irregular
 indentation

On Sun, Feb 26, 2023 at 12:28:20PM +0000, Shibo Li wrote:
> This patch fixes the problem of irregular indentation
> 
> Signed-off-by: Shibo Li <zzutcyha@....com>
> ---
>  drivers/staging/rtl8712/rtl871x_mlme.c | 182 ++++++++++++-------------
>  1 file changed, 91 insertions(+), 91 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index fccfa0915a02..d8af4f370060 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -51,7 +51,7 @@ int r8712_init_mlme_priv(struct _adapter *padapter)
>  	set_scanned_network_val(pmlmepriv, 0);
>  	memset(&pmlmepriv->assoc_ssid, 0, sizeof(struct ndis_802_11_ssid));
>  	pbuf = kmalloc_array(MAX_BSS_CNT, sizeof(struct wlan_network),
> -			     GFP_ATOMIC);
> +				GFP_ATOMIC);

The original was correct and the new version is incorrect.  Checkpatch
will complain about the new version if you re-run checkpatch on the file
(not if you run it on the patch itself).

CHECK: Alignment should match open parenthesis
#54: FILE: drivers/staging/rtl8712/rtl871x_mlme.c:54:
+       pbuf = kmalloc_array(MAX_BSS_CNT, sizeof(struct wlan_network),
+                               GFP_ATOMIC);

regards,
dan carpenter