linux-kernel - Re: [PATCH bpf-next] riscv, bpf: fix patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a2193be-70db-1681-7e4b-ff12f4c56d4b@huawei.com>
Date:   Mon, 27 Feb 2023 14:51:47 +0800
From:   Pu Lehui <pulehui@...wei.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        <linux-kernel@...r.kernel.org>
CC:     kernel test robot <lkp@...el.com>,
        Luke Nelson <luke.r.nels@...il.com>,
        Xi Wang <xi.wang@...il.com>, <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Björn Töpel <bjorn@...nel.org>,
        <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH bpf-next] riscv, bpf: fix patch_text implicit declaration



On 2023/2/27 12:02, Randy Dunlap wrote:
> bpf_jit_comp64.c uses patch_text(), so add it to a local header file
> to prevent the build error:
> 
> ../arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke':
> ../arch/riscv/net/bpf_jit_comp64.c:691:23: error: implicit declaration of function 'patch_text'; did you mean 'path_get'? [-Werror=implicit-function-declaration]
>    691 |                 ret = patch_text(ip, new_insns, ninsns);
>        |                       ^~~~~~~~~~
> 
> Fixes: 596f2e6f9cf4 ("riscv, bpf: Add bpf_arch_text_poke support for RV64")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/r/202302271000.Aj4nMXbZ-lkp@intel.com
> Cc: Pu Lehui <pulehui@...wei.com>
> Cc: Luke Nelson <luke.r.nels@...il.com>
> Cc: Xi Wang <xi.wang@...il.com>
> Cc: bpf@...r.kernel.org
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: Andrii Nakryiko <andrii@...nel.org>
> Cc: Paul Walmsley <paul.walmsley@...ive.com>
> Cc: Palmer Dabbelt <palmer@...belt.com>
> Cc: Albert Ou <aou@...s.berkeley.edu>
> Cc: "Björn Töpel" <bjorn@...nel.org>
> Cc: linux-riscv@...ts.infradead.org
> ---
> What is the proper path to have this merged soon to stop build
> errors?
> 
>   arch/riscv/net/bpf_jit.h |    1 +
>   1 file changed, 1 insertion(+)
> 
> diff -- a/arch/riscv/net/bpf_jit.h b/arch/riscv/net/bpf_jit.h
> --- a/arch/riscv/net/bpf_jit.h
> +++ b/arch/riscv/net/bpf_jit.h
> @@ -12,6 +12,7 @@
>   #include <linux/bpf.h>
>   #include <linux/filter.h>
>   #include <asm/cacheflush.h>
> +#include <asm/patch.h>
>   

Thanks Randy. Since patch_text is only used in riscv64 at present, I 
think it is appropriate to add it to arch/riscv/net/bpf_jit_comp64.c

>   static inline bool rvc_enabled(void)
>   {