linux-kernel - Re: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV initial domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <58248946-f0ad-ae3b-57a6-f7c15fd35198@suse.com>
Date:   Mon, 27 Feb 2023 08:12:16 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>, xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV
 initial domain

On 24.02.23 22:00, Boris Ostrovsky wrote:
> 
> On 2/23/23 4:32 AM, Juergen Gross wrote:
>> +
>> +	for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) {
>> +		op.u.read_memtype.reg = reg;
>> +		if (HYPERVISOR_platform_op(&op))
>> +			break;
> 
> 
> If we fail on the first iteration, do we still want to mark MTRRs are 
> enabled/set in mtrr_overwrite_state()?

Hmm, good idea.

I think we should just drop the call of mtrr_overwrite_state() in this
case.


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)