linux-kernel - Re: [PATCH] drm/shmem-helper: Revert accidental non-GPL export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c94a0b2c-f061-3030-ecb7-abf0a16faa1d@suse.de>
Date:   Mon, 27 Feb 2023 10:07:10 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Asahi Lina <lina@...hilina.net>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Javier Martinez Canillas <javierm@...hat.com>
Cc:     Noralf Trønnes <noralf@...nnes.org>,
        Rob Herring <robh@...nel.org>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Dmitry Osipenko <dmitry.osipenko@...labora.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/shmem-helper: Revert accidental non-GPL export

Hi

Am 27.02.23 um 10:04 schrieb Asahi Lina:
> The referenced commit added a wrapper for drm_gem_shmem_get_pages_sgt(),
> but in the process it accidentally changed the export type from GPL to
> non-GPL. Switch it back to GPL.
> 
> Reported-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
> Fixes: ddddedaa0db9 ("drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()")
> Signed-off-by: Asahi Lina <lina@...hilina.net>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Thanks a lot. I'll add your patch to drm-misc-fixes ASAP.

Best regards
Thomas

> ---
>   drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 7e5c6a8d0212..75185a960fc4 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -744,7 +744,7 @@ struct sg_table *drm_gem_shmem_get_pages_sgt(struct drm_gem_shmem_object *shmem)
>   
>   	return sgt;
>   }
> -EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt);
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt);
>   
>   /**
>    * drm_gem_shmem_prime_import_sg_table - Produce a shmem GEM object from
> 
> ---
> base-commit: f3a2439f20d918930cc4ae8f76fe1c1afd26958f
> change-id: 20230227-shmem-export-fix-85fde1351104
> 
> Thank you,
> ~~ Lina
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)