linux-kernel - Re: [PATCH v3] nfc: fdp: add null check of devm_kmalloc_array in fdp_nci_i2c_read_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76e2daf5-0f04-ce02-7c16-1eff3576b3de@linaro.org>
Date:   Mon, 27 Feb 2023 10:44:31 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     void0red <void0red@...il.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        simon.horman@...igine.com
Subject: Re: [PATCH v3] nfc: fdp: add null check of devm_kmalloc_array in
 fdp_nci_i2c_read_device_properties

On 27/02/2023 10:30, void0red wrote:
> From: Kang Chen <void0red@...il.com>
> 
> devm_kmalloc_array may fails, *fw_vsc_cfg might be null and cause
> out-of-bounds write in device_property_read_u8_array later.
> 
> Fixes: a06347c04c13 ("NFC: Add Intel Fields Peak NFC solution driver")
> Signed-off-by: Kang Chen <void0red@...il.com>
> ---
> v3 -> v2: remove useless prompt and blank lines between tags.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof