linux-kernel - Re: [PATCH 24/27] firmware: xilinx: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63a98249-3c6d-dd50-b523-64c69173d447@amd.com>
Date:   Mon, 27 Feb 2023 12:51:13 +0100
From:   Michal Simek <michal.simek@....com>
To:     Nick Alcock <nick.alcock@...cle.com>, <mcgrof@...nel.org>
CC:     <linux-modules@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Michal Simek <michal.simek@...inx.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 24/27] firmware: xilinx: remove MODULE_LICENSE in
 non-modules



On 2/24/23 16:08, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> ---
>   drivers/nvmem/zynqmp_nvmem.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c
> index e28d7b133e11..844c1d861dea 100644
> --- a/drivers/nvmem/zynqmp_nvmem.c
> +++ b/drivers/nvmem/zynqmp_nvmem.c
> @@ -78,4 +78,3 @@ module_platform_driver(zynqmp_nvmem_driver);
> 
>   MODULE_AUTHOR("Michal Simek <michal.simek@...inx.com>, Nava kishore Manne <navam@...inx.com>");
>   MODULE_DESCRIPTION("ZynqMP NVMEM driver");
> -MODULE_LICENSE("GPL");
> --
> 2.39.1.268.g9de2f9a303
> 

I would prefer to fix this by changing Kconfig symbol from bool to tristate.

Thanks,
Michal