linux-kernel - Re: [PATCH 4/9] w1: ds2482: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2023 13:36:28 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Wolfram Sang <wsa@...nel.org>, kernel@...gutronix.de,
        Evgeniy Polyakov <zbr@...emap.net>, Crt Mori <cmo@...exis.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] w1: ds2482: Convert to i2c's .probe_new()

On Fri, 24 Feb 2023 13:05:55 +0100, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Link: https://lore.kernel.org/lkml/20221118224540.619276-596-uwe@kleine-koenig.org
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/w1/masters/ds2482.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
> index 62c44616d8a9..3d8b51316bef 100644
> --- a/drivers/w1/masters/ds2482.c
> +++ b/drivers/w1/masters/ds2482.c
> @@ -442,8 +442,7 @@ static u8 ds2482_w1_set_pullup(void *data, int delay)
>  }
>  
>  
> -static int ds2482_probe(struct i2c_client *client,
> -			const struct i2c_device_id *id)
> +static int ds2482_probe(struct i2c_client *client)
>  {
>  	struct ds2482_data *data;
>  	int err = -ENODEV;
> @@ -553,7 +552,7 @@ static struct i2c_driver ds2482_driver = {
>  	.driver = {
>  		.name	= "ds2482",
>  	},
> -	.probe		= ds2482_probe,
> +	.probe_new	= ds2482_probe,
>  	.remove		= ds2482_remove,
>  	.id_table	= ds2482_id,
>  };

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support