linux-kernel - Re: [PATCH v5 2/2] hwmon: (sfctemp) Add StarFive JH71x0 temperature sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/y4LunvriV2RYwu@wendy>
Date:   Mon, 27 Feb 2023 14:03:26 +0000
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Hal Feng <hal.feng@...rfivetech.com>
CC:     <linux-hwmon@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jonathan Corbet <corbet@....net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Emil Renner Berthing <emil.renner.berthing@...onical.com>,
        Samin Guo <samin.guo@...rfivetech.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/2] hwmon: (sfctemp) Add StarFive JH71x0 temperature
 sensor

On Mon, Feb 27, 2023 at 09:41:25PM +0800, Hal Feng wrote:
> From: Emil Renner Berthing <kernel@...il.dk>
> 
> Add driver for the StarFive JH71x0 temperature sensor. You
> can enable/disable it and read temperature in milli Celcius
> through sysfs.
> 
> Signed-off-by: Emil Renner Berthing <kernel@...il.dk>
> Co-developed-by: Samin Guo <samin.guo@...rfivetech.com>
> Signed-off-by: Samin Guo <samin.guo@...rfivetech.com>
> Signed-off-by: Hal Feng <hal.feng@...rfivetech.com>

> +config SENSORS_SFCTEMP
> +	tristate "Starfive JH71x0 temperature sensor"
> +	depends on SOC_STARFIVE || COMPILE_TEST

We (or I?) am trying to homogenise RISC-V with the rest of the kernel by
using ARCH_FOO rather than SOC_FOO. We've currently got a mix of both,
due to companies that started out with RISC-V having SOC_ symbols &
those with history in other archs having ARCH_ ones.
The ARCH_ definitions landed in mainline this week, so if you end up
resubmitting this driver, it'd save me a conversion if you were to use
the ARCH_ variant.

Thanks,
Conor.

> +	help
> +	  If you say yes here you get support for temperature sensor
> +	  on the Starfive JH71x0 SoCs.
> +
> +	  This driver can also be built as a module.  If so, the module
> +	  will be called sfctemp.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)