linux-kernel - Re: [PATCH] Fix snprintf format warnings during 'alsa' kselftest compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/y6MNh8yXcsQWWj@sirena.org.uk>
Date:   Mon, 27 Feb 2023 14:12:00 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Ivan Orlov <ivan.orlov0322@...il.com>
Cc:     perex@...ex.cz, tiwai@...e.com, shuah@...nel.org,
        alsa-devel@...a-project.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] Fix snprintf format warnings during 'alsa' kselftest
 compilation

On Thu, Feb 23, 2023 at 11:14:56PM +0300, Ivan Orlov wrote:

> I compiled the test via gcc 11.3.0 without any custom options, the arch is
> x86_64. There were five warnings during the test compilation, and all of
> them were caused by incorrect format in 'snprintf' function calls. As I
> know, using incorrect format in 'snprintf' creates an undefined behavior.
> Maybe there is a point to fix it?

The question is more where does the warning come from and is this a good
fix - a common pattern where generic types like size_t get used is that
the underlying type changes between platforms and warnings just get
moved about by changing the printf format around.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)