linux-kernel - Re: [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac grouping for ethtool statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca1f4970-206d-64f2-d210-e4e54b59d301@intel.com>
Date:   Mon, 27 Feb 2023 15:31:35 +0100
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Vladimir Oltean <olteanv@...il.com>
CC:     Rakesh Sankaranarayanan <rakesh.sankaranarayanan@...rochip.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <woojung.huh@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        <andrew@...n.ch>, <f.fainelli@...il.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac grouping
 for ethtool statistics

From: Vladimir Oltean <olteanv@...il.com>
Date: Fri, 24 Feb 2023 23:53:49 +0200

> On Fri, Feb 24, 2023 at 05:07:01PM +0100, Alexander Lobakin wrote:
>> It's not so common for people to show up back in the thread after you
>> ask them to show godbolt / asm code comparison.
> 
> idk what godbolt is, but if it's some sort of online compiler, then I
> suppose it's of limited usefulness for the Linux kernel.

Yeah it's an online compiler, which can spit out assembly code. For
testing non-complex stuff or macros it's often enough.

> 
> Easiest way to see a disassembly (also has C code interleaved) would be
> this:
> 
> make drivers/net/dsa/microchip/ksz_ethtool.lst

Oh, nice! I didn't know Kbuild has capability of listing the assembly
code built-in. I was adding it manually to Makefiles when needed >_<
Thanks! :D

> 
> This is also useful to see precisely which instruction went boom in case
> there's a NULL pointer dereference or something like that.

Thanks,
Olek