linux-kernel - Re: [PATCH 0/8] drivers: select REGMAP instead of depending on it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6a95a337-2972-427f-635d-5ef4e91a82fa@infradead.org>
Date:   Mon, 27 Feb 2023 08:07:04 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Hans de Goede <hdegoede@...hat.com>, linux-kernel@...r.kernel.org
Cc:     Andrew Jeffery <andrew@...id.au>, Corey Minyard <minyard@....org>,
        openipmi-developer@...ts.sourceforge.net,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Riku Voipio <riku.voipio@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, Michael Walle <michael@...le.cc>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        linux-gpio@...r.kernel.org, Dan Murphy <dmurphy@...com>,
        Pavel Machek <pavel@....cz>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Lee Jones <lee@...nel.org>, linux-leds@...r.kernel.org,
        Darren Hart <dvhart@...radead.org>,
        Michael Shych <michaelsh@...dia.com>,
        Mark Gross <markgross@...nel.org>,
        Vadim Pasternak <vadimp@...dia.com>,
        platform-driver-x86@...r.kernel.org,
        Yegnesh S Iyer <yegnesh.s.iyer@...el.com>,
        Bin Gao <bin.gao@...el.com>, Zhang Rui <rui.zhang@...el.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>, linux-pm@...r.kernel.org,
        Oskar Senft <osk@...gle.com>, linux-serial@...r.kernel.org
Subject: Re: [PATCH 0/8] drivers: select REGMAP instead of depending on it



On 2/27/23 01:31, Hans de Goede wrote:
> Hi Randy,
> 
> On 2/26/23 06:39, Randy Dunlap wrote:
>> REGMAP is a hidden (not user visible) symbol. Users cannot set it
>> directly thru "make *config", so drivers should select it instead of
>> depending on it if they need it.
>>
>> Consistently using "select" or "depends on" can also help reduce
>> Kconfig circular dependency issues.
>>
>> REGMAP is selected 94 times and is depended on 11 times in
>> current linux-next. Eliminate the uses of "depends on" by
>> converting them to "select".
> 
> Thank you for your work on this. Mixing of depends on vs select
> is a real problem with many Kconfig symbols.
> 
>>  [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
>>  [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
>>  [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
>>  [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
>>  [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
>>  [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
>>  [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
>>  [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
> 
> For patch 5/8 and 6/8, do you want me to merge them through the pdx86
> (platform-drivers-x86) tree, or do you plan to merge this whole series
> in one go through some other tree?

Hi Hans,
Please merge them thru the pdx86 tree.

Thanks.

> If you plan to merge the whole series through some other tree,
> here is my acked by for doing so for 5/8 and 6/8:
> 
> Acked-by: Hans de Goede <hdegoede@...hat.com>
> 
> Regards,
> 
> Hans
> 
> 
> 
> 
>>
>> diffstat:
>>  drivers/char/ipmi/Kconfig         |    3 ++-
>>  drivers/clk/Kconfig               |    2 +-
>>  drivers/gpio/Kconfig              |    2 +-
>>  drivers/leds/Kconfig              |    2 +-
>>  drivers/platform/mellanox/Kconfig |    9 ++++-----
>>  drivers/platform/x86/Kconfig      |    3 ++-
>>  drivers/thermal/intel/Kconfig     |    3 ++-
>>  drivers/tty/serial/8250/Kconfig   |    3 ++-
>>  8 files changed, 15 insertions(+), 12 deletions(-)
>>
>> Cc: Andrew Jeffery <andrew@...id.au>
>> Cc: Corey Minyard <minyard@....org>
>> Cc: openipmi-developer@...ts.sourceforge.net
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Riku Voipio <riku.voipio@...aro.org>
>> Cc: Stephen Boyd <sboyd@...nel.org>
>> Cc: Michael Turquette <mturquette@...libre.com>
>> Cc: linux-clk@...r.kernel.org
>> Cc: Michael Walle <michael@...le.cc>
>> Cc: Linus Walleij <linus.walleij@...aro.org>
>> Cc: Bartosz Golaszewski <brgl@...ev.pl>
>> Cc: linux-gpio@...r.kernel.org
>> Cc: Dan Murphy <dmurphy@...com>
>> Cc: Pavel Machek <pavel@....cz>
>> Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>
>> Cc: Lee Jones <lee@...nel.org>
>> Cc: linux-leds@...r.kernel.org
>> Cc: Darren Hart <dvhart@...radead.org>
>> Cc: Hans de Goede <hdegoede@...hat.com>
>> Cc: Michael Shych <michaelsh@...dia.com>
>> Cc: Mark Gross <markgross@...nel.org>
>> Cc: Vadim Pasternak <vadimp@...dia.com>
>> Cc: platform-driver-x86@...r.kernel.org
>> Cc: Yegnesh S Iyer <yegnesh.s.iyer@...el.com>
>> Cc: Bin Gao <bin.gao@...el.com>
>> Cc: Zhang Rui <rui.zhang@...el.com>
>> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
>> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
>> Cc: Amit Kucheria <amitk@...nel.org>
>> Cc: linux-pm@...r.kernel.org
>> Cc: Oskar Senft <osk@...gle.com>
>> Cc: linux-serial@...r.kernel.org
>>
> 

-- 
~Randy