linux-kernel - Re: [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420 compatible for the MIPI video phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/zZ/UcWyT2EWAiL@duo.ucw.cz>
Date:   Mon, 27 Feb 2023 17:27:41 +0100
From:   Pavel Machek <pavel@....cz>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Markuss Broks <markuss.broks@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 2/3] ARM: dts: exynos: Use Exynos5420
 compatible for the MIPI video phy

Hi!

> From: Markuss Broks <markuss.broks@...il.com>
> 
> [ Upstream commit 5d5aa219a790d61cad2c38e1aa32058f16ad2f0b ]
> 
> For some reason, the driver adding support for Exynos5420 MIPI phy
> back in 2016 wasn't used on Exynos5420, which caused a kernel panic.
> Add the proper compatible for it.

This is likely bad idea for 4.14, as that compatible is still in use:

drivers/phy/samsung/phy-exynos-mipi-video.c:		.compatible = "samsung,s5pv210-mipi-video-phy",
arch/arm/boot/dts/exynos5420.dtsi:			compatible = "samsung,s5pv210-mipi-video-phy";
arch/arm/boot/dts/exynos3250.dtsi:			compatible = "samsung,s5pv210-mipi-video-phy";
arch/arm/boot/dts/exynos4.dtsi:		compatible = "samsung,s5pv210-mipi-video-phy";

phy-exynos-mipi-video.c lists other compatibles, too, but with
different data.

Best regards,
									Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)