linux-kernel - Re: [PATCH] efi: x86: make kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXGwZxjjB3ojmH5cHDOLnveGY2vSz7t=xgj2dN7dg1K09Q@mail.gmail.com>
Date:   Mon, 27 Feb 2023 17:34:38 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, linux-efi@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi: x86: make kobj_type structure constant

On Mon, 27 Feb 2023 at 04:09, Thomas Weißschuh <linux@...ssschuh.net> wrote:
>
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Thanks, I'll queue these up after the merge window.

> ---
>  arch/x86/platform/efi/runtime-map.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/efi/runtime-map.c b/arch/x86/platform/efi/runtime-map.c
> index bbee682ef8cd..a6f02cef3ca2 100644
> --- a/arch/x86/platform/efi/runtime-map.c
> +++ b/arch/x86/platform/efi/runtime-map.c
> @@ -93,7 +93,7 @@ static void map_release(struct kobject *kobj)
>         kfree(entry);
>  }
>
> -static struct kobj_type __refdata map_ktype = {
> +static const struct kobj_type __refconst map_ktype = {
>         .sysfs_ops      = &map_attr_ops,
>         .default_groups = def_groups,
>         .release        = map_release,
>
> ---
> base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
> change-id: 20230227-kobj_type-x86-efi-7591b1343b08
>
> Best regards,
> --
> Thomas Weißschuh <linux@...ssschuh.net>
>