linux-kernel - Re: [PATCH 2/3] gpio: gpio-regmap: Expose struct gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/1xG+K1yzcRZtZ4@fedora>
Date:   Mon, 27 Feb 2023 22:12:27 -0500
From:   William Breathitt Gray <william.gray@...aro.org>
To:     Michael Walle <michael@...le.cc>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl, broonie@...nel.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        quarium@...il.com, jhentges@...esio.com, jay.dolan@...esio.com
Subject: Re: [PATCH 2/3] gpio: gpio-regmap: Expose struct gpio_regmap in
 linux/gpio/regmap.h

On Tue, Feb 28, 2023 at 09:44:02PM +0100, Michael Walle wrote:
> Hi,
> 
> Am 2023-02-28 02:53, schrieb William Breathitt Gray:
> > A struct gpio_regmap is passed as a parameter for reg_mask_xlate(), but
> > for callbacks to access its members the declaration must be exposed.
> 
> That parameter is only an opaque one to call any gpio_regmap_*().
> 
> > Move the struct gpio_regmap declaration from drivers/gpio/gpio-regmap.c
> > to include/linux/gpio/regmap.h so callbacks can properly interact with
> > struct gpio_regmap members.
> 
> That struct should be kept private. It seems you only need the
> regmap. Either introduce a gpio_regmap_get_regmap() or add the
> regmap to a private struct and use gpio_regmap_get_drvdata().
> 
> -michael

Ah, I'll drop this patch then and use gpio_regmap_get_drvdata() in v2
instead to get access to the regmap.

William Breathitt Gray

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)