linux-kernel - Re: [PATCH v2 2/2] leds: add aw20xx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/5xBGFC3b9Chdtb@duo.ucw.cz>
Date:   Tue, 28 Feb 2023 22:24:20 +0100
From:   Pavel Machek <pavel@....cz>
To:     Martin Kurbanov <mmkurbanov@...rdevices.ru>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lee Jones <lee@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...rdevices.ru
Subject: Re: [PATCH v2 2/2] leds: add aw20xx driver

Hi!

> +config LEDS_AW200XX
> +	tristate "LED support for Awinic AW20036/AW20054/AW20072"
> +	depends on LEDS_CLASS
> +	depends on I2C
> +	help
> +	  This option enables support for the AW20036/AW20054/AW20072 LED driver.
> +	  It is a 3x12/6x9/6x12 matrix LED driver programmed via
> +	  an I2C interface, up to 36/54/72 LEDs or 12/18/24 RGBs,
> +	  3 pattern controllers for auto breathing or group dimming control.

I'm afraid this should be handled as a display, not as an array of
individual LEDs.

Plus RGB LEDs should certainly be handled using multicolor class.

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)