linux-kernel - Re: [PATCH] serial: 8250_fsl: fix handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e7d9a975-69b8-0290-102e-ac3fce792952@kernel.org>
Date:   Tue, 28 Feb 2023 07:27:46 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] serial: 8250_fsl: fix handle_irq locking

On 27. 02. 23, 9:50, Johan Hovold wrote:
> The 8250 handle_irq callback is not just called from the interrupt
> handler but also from a timer callback when polling (e.g. for ports
> without an interrupt line). Consequently the callback must explicitly
> disable interrupts to avoid a potential deadlock with another interrupt
> in polled mode.
> 
> Fix up the two paths in the freescale callback that failed to re-enable
> interrupts when polling.

Huh.

Acked-by: Jiri Slaby <jirislaby@...nel.org>

-- 
js
suse labs