linux-kernel - Re: include/asm-generic/div64.h:238:36: error: passing argument 1 of '__div64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdX0ufx4FaoXR8ai53xeact4DC4HNhA8N6KwoOsw3yUMOg@mail.gmail.com>
Date:   Tue, 28 Feb 2023 09:52:31 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     kernel test robot <lkp@...el.com>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: include/asm-generic/div64.h:238:36: error: passing argument 1 of
 '__div64_32' from incompatible pointer type

On Mon, Feb 27, 2023 at 11:33 PM kernel test robot <lkp@...el.com> wrote:
> FYI, the error/warning still remains.
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   982818426a0ffaf93b0621826ed39a84be3d7d62
> commit: 29e8142b5623b5949587bcc4f591c4e6595c4aca power: supply: Introduce Qualcomm PMIC GLINK power supply
> date:   2 weeks ago
> config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20230228/202302280619.kO2cWoIT-lkp@intel.com/config)
> compiler: arceb-elf-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=29e8142b5623b5949587bcc4f591c4e6595c4aca
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 29e8142b5623b5949587bcc4f591c4e6595c4aca
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@...el.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202302280619.kO2cWoIT-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    In file included from ./arch/arc/include/generated/asm/div64.h:1,
>                     from include/linux/math.h:6,
>                     from include/linux/math64.h:6,
>                     from include/linux/time64.h:5,
>                     from include/linux/restart_block.h:10,
>                     from include/linux/thread_info.h:14,
>                     from include/asm-generic/preempt.h:5,
>                     from ./arch/arc/include/generated/asm/preempt.h:1,
>                     from include/linux/preempt.h:78,
>                     from include/linux/rcupdate.h:27,
>                     from include/linux/rculist.h:11,
>                     from include/linux/pid.h:5,
>                     from include/linux/sched.h:14,
>                     from include/linux/ratelimit.h:6,
>                     from include/linux/dev_printk.h:16,
>                     from include/linux/device.h:15,
>                     from include/linux/auxiliary_bus.h:11,
>                     from drivers/power/supply/qcom_battmgr.c:6:
>    drivers/power/supply/qcom_battmgr.c: In function 'qcom_battmgr_sm8350_callback':
>    include/asm-generic/div64.h:222:35: warning: comparison of distinct pointer types lacks a cast
>      222 |         (void)(((typeof((n)) *)0) == ((uint64_t *)0));  \
>          |                                   ^~
>    drivers/power/supply/qcom_battmgr.c:1130:25: note: in expansion of macro 'do_div'
>     1130 |                         do_div(battmgr->status.percent, 100);
>          |                         ^~~~~~
>    In file included from include/linux/dev_printk.h:14:
>    include/asm-generic/div64.h:234:32: warning: right shift count >= width of type [-Wshift-count-overflow]
>      234 |         } else if (likely(((n) >> 32) == 0)) {          \
>          |                                ^~
>    include/linux/compiler.h:77:45: note: in definition of macro 'likely'
>       77 | # define likely(x)      __builtin_expect(!!(x), 1)
>          |                                             ^
>    drivers/power/supply/qcom_battmgr.c:1130:25: note: in expansion of macro 'do_div'
>     1130 |                         do_div(battmgr->status.percent, 100);
>          |                         ^~~~~~
> >> include/asm-generic/div64.h:238:36: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
>      238 |                 __rem = __div64_32(&(n), __base);       \
>          |                                    ^~~~
>          |                                    |
>          |                                    unsigned int *
>    drivers/power/supply/qcom_battmgr.c:1130:25: note: in expansion of macro 'do_div'
>     1130 |                         do_div(battmgr->status.percent, 100);
>          |                         ^~~~~~
>    include/asm-generic/div64.h:213:38: note: expected 'uint64_t *' {aka 'long long unsigned int *'} but argument is of type 'unsigned int *'
>      213 | extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
>          |                            ~~~~~~~~~~^~~~~~~~
>    cc1: some warnings being treated as errors

Fix available for two weeks:
https://lore.kernel.org/all/20230214132052.1556699-1-arnd@kernel.org

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds