linux-kernel - RE: [RFC] sched: show cpu number when sched_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DU0PR04MB94175D2112D1398CFCF7714D88AC9@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date:   Tue, 28 Feb 2023 01:13:17 +0000
From:   Peng Fan <peng.fan@....com>
To:     Phil Auld <pauld@...hat.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "juri.lelli@...hat.com" <juri.lelli@...hat.com>,
        "vincent.guittot@...aro.org" <vincent.guittot@...aro.org>,
        "dietmar.eggemann@....com" <dietmar.eggemann@....com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "bsegall@...gle.com" <bsegall@...gle.com>,
        "mgorman@...e.de" <mgorman@...e.de>,
        "bristot@...hat.com" <bristot@...hat.com>,
        "vschneid@...hat.com" <vschneid@...hat.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC] sched: show cpu number when sched_show_task

> Subject: Re: [RFC] sched: show cpu number when sched_show_task

Should I send a formal patch with Phil's R-b or this is fine since no more comments?

Thanks,
Peng.

> 
> On Wed, Feb 08, 2023 at 08:46:55PM +0800 Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > It would be helpful to show cpu number when dump task. Such as when
> > doing system suspend, we could know the failed freezing process run on
> > which cpu.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  kernel/sched/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c index
> > daff72f00385..0c7a1b2f7baf 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -8876,7 +8876,7 @@ void sched_show_task(struct task_struct *p)
> >  	if (!try_get_task_stack(p))
> >  		return;
> >
> > -	pr_info("task:%-15.15s state:%c", p->comm, task_state_to_char(p));
> > +	pr_info("task:%-15.15s state:%c cpu:0x%x", p->comm,
> > +task_state_to_char(p), task_cpu(p));
> >
> >  	if (task_is_running(p))
> >  		pr_cont("  running task    ");
> > --
> > 2.37.1
> >
> 
> Looks useful, thanks.
> 
> Reviewed-by: Phil Auld <pauld@...hat.com>
> 
> 
> --