linux-kernel - Re: [Patch v5] dt-bindings: media: s5p-mfc: convert bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c8c3e57-16b4-43cc-941a-61f251bfe1f9@linaro.org>
Date:   Tue, 28 Feb 2023 11:23:35 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Aakarsh Jain <aakarsh.jain@...sung.com>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc:     m.szyprowski@...sung.com, andrzej.hajda@...el.com,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        ezequiel@...guardiasur.com.ar, jernej.skrabec@...il.com,
        benjamin.gaignard@...labora.com, krzysztof.kozlowski+dt@...aro.org,
        stanimir.varbanov@...aro.org, dillon.minfei@...il.com,
        david.plowman@...pberrypi.com, mark.rutland@....com,
        robh+dt@...nel.org, krzk+dt@...nel.org, andi@...zian.org,
        alim.akhtar@...sung.com, aswani.reddy@...sung.com,
        pankaj.dubey@...sung.com
Subject: Re: [Patch v5] dt-bindings: media: s5p-mfc: convert bindings to
 json-schema

On 27/02/2023 12:38, Aakarsh Jain wrote:
>>> +          - samsung,mfc-v5              # Exynos4
>>> +          - samsung,mfc-v6              # Exynos5
>>> +      - items:
>>> +          - enum:
>>> +              - samsung,exynos3250-mfc  # Exynos3250
>>> +          - const: samsung,mfc-v7       # Fall back for Exynos3250
>>> +      - enum:
>>> +          - samsung,mfc-v7              # Exynos5420
>>> +          - samsung,mfc-v8              # Exynos5800
>>> +          - samsung,exynos5433-mfc      # Exynos5433
>>> +          - samsung,mfc-v10             # Exynos7880
>>
>> Why this and first enum are separate?  I didn't notice it before...
>> Usually we have only one enum for one-compatible variants. Also, sort them
>> by compatible.
>>
> okay.
> I will keep it in this way
> properties:
>   compatible:
>     oneOf:
>       - const: samsung,mfc-v5              # Exynos4
>       - const: samsung,mfc-v6              # Exynos5
>       - const: samsung,mfc-v7              # Exynos5420
>       - const: samsung,mfc-v8              # Exynos5800
>       - const: samsung,exynos5433-mfc      # Exynos5433
>       - const: samsung,mfc-v10             # Exynos7880

These should still be an enum (and sorted by compatible).

>       - items:
>           - const: samsung,exynos3250-mfc  # Exynos3250
>           - const: samsung,mfc-v7          # Fall back for Exynos3250
> 
> Will this be fine?



Best regards,
Krzysztof