linux-kernel - Re: [PATCH v2 1/2] MIPS: ebpf jit: Implement DADDI workarounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6198f1c8-29b7-dba4-2469-2a99eb03c83e@linaro.org>
Date:   Tue, 28 Feb 2023 13:02:22 +0100
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>, linux-mips@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, tsbogend@...ha.franken.de,
        johan.almbladh@...finetworks.com, paulburton@...nel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH v2 1/2] MIPS: ebpf jit: Implement DADDI workarounds

On 28/2/23 12:33, Jiaxun Yang wrote:
> For DADDI errata we just workaround by disable immediate operation
> for BPF_ADD / BPF_SUB to avoid generation of DADDIU.
> 
> All other use cases in JIT won't cause overflow thus they are all safe.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> ---
> v2: Drop 64BIT ifdef
> ---
>   arch/mips/Kconfig            | 1 -
>   arch/mips/net/bpf_jit_comp.c | 4 ++++
>   2 files changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>