[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3d87834c-0800-b648-157b-ed00ebbce450@kernel.org>
Date: Tue, 28 Feb 2023 10:19:10 -0300
From: Daniel Bristot de Oliveira <bristot@...nel.org>
To: Nick Alcock <nick.alcock@...cle.com>, mcgrof@...nel.org
Cc: linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
Steven Rostedt <rostedt@...dmis.org>,
Masami Hiramatsu <mhiramat@...nel.org>,
linux-trace-devel@...r.kernel.org,
linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH 14/20] rv/reactor: remove MODULE_LICENSE in non-modules
On 2/28/23 10:02, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
Acked-by: Daniel Bristot de Oliveira <bristot@...nel.org>
-- Daniel
Powered by blists - more mailing lists