linux-kernel - Re: [PATCH 08/20] remoteproc: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f819a73c-ba92-3106-cd25-2ce5cb85064c@quicinc.com>
Date:   Tue, 28 Feb 2023 19:05:31 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Nick Alcock <nick.alcock@...cle.com>, <mcgrof@...nel.org>
CC:     <linux-modules@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        <linux-remoteproc@...r.kernel.org>
Subject: Re: [PATCH 08/20] remoteproc: remove MODULE_LICENSE in non-modules



On 2/28/2023 6:32 PM, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> Cc: Bjorn Andersson <andersson@...nel.org>
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> Cc: linux-remoteproc@...r.kernel.org

Acked-by: Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh
> ---
>   drivers/remoteproc/remoteproc_core.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 1cd4815a6dd19..de1ace44cb57b 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -2765,5 +2765,4 @@ static void __exit remoteproc_exit(void)
>   }
>   module_exit(remoteproc_exit);
>   
> -MODULE_LICENSE("GPL v2");
>   MODULE_DESCRIPTION("Generic Remote Processor Framework");