lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de>
Date:   Tue, 28 Feb 2023 14:55:04 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Thierry Reding <thierry.reding@...il.com>,
        Munehisa Kamata <kamatam@...zon.com>,
        Jiancheng Xue <xuejiancheng@...ilicon.com>,
        yuanjian <yuanjian12@...ilicon.com>,
        Rob Herring <robh@...nel.org>,
        Benson Leung <bleung@...omium.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Cc:     linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guenter Roeck <groeck@...omium.org>,
        chrome-platform@...ts.linux.dev, kernel@...gutronix.de
Subject: [PATCH 0/4] pwm: Ensure .polarity is set in .get_state()

Hello,

in the context of the discussion with Munehisa Kamata about the meson driver
not setting .polarity in .get_state() I checked the other drivers for the same
issue. The identified drivers are fixed here. For three of them
zero-initializing *state would be good enough, still I think setting the
polarity explicitly is a good idea. For the hibvt driver (that supports
both polarities) the change is a real improvement.

Note I didn't touch the meson driver here that requires some non-trivial
updates that I don't want to tackle without hardware to test.

Best regards
Uwe

Uwe Kleine-König (4):
  pwm: hibvt: Explicitly set .polarity in .get_state()
  pwm: cros-ec: Explicitly set .polarity in .get_state()
  pwm: iqs620a: Explicitly set .polarity in .get_state()
  pwm: sprd: Explicitly set .polarity in .get_state()

 drivers/pwm/pwm-cros-ec.c | 1 +
 drivers/pwm/pwm-hibvt.c   | 1 +
 drivers/pwm/pwm-iqs620a.c | 1 +
 drivers/pwm/pwm-sprd.c    | 1 +
 4 files changed, 4 insertions(+)


base-commit: 7a77daf8223e772a225d6aa6202a5b1ae2392caf
-- 
2.39.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ