[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <af5fa75b-1831-67cc-f644-33adfd2e1031@linaro.org>
Date: Tue, 28 Feb 2023 15:07:51 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: William Qiu <william.qiu@...rfivetech.com>,
devicetree@...r.kernel.org, linux-pwm@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Thierry Reding <thierry.reding@...il.com>,
Hal Feng <hal.feng@...rfivetech.com>
Subject: Re: [PATCH v1 1/2] dt-bindings: PWM: Add StarFive PWM module
On 28/02/2023 10:13, William Qiu wrote:
> Add documentation to describe StarFive Pulse Width Modulation
> controller driver.
>
> Signed-off-by: William Qiu <william.qiu@...rfivetech.com>
> ---
> .../devicetree/bindings/pwm/pwm-starfive.yaml | 54 +++++++++++++++++++
> 1 file changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-starfive.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-starfive.yaml b/Documentation/devicetree/bindings/pwm/pwm-starfive.yaml
> new file mode 100644
> index 000000000000..4ba2a8cc5344
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-starfive.yaml
Filename based on compatible, so starfive,jh7110-pwm.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/pwm-starfive.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive PWM controller
> +
> +maintainers:
> + - William Qiu <william.qiu@...rfivetech.com>
> +
> +description:
> + StarFive SoCs contain PWM and when operating in PWM mode, the PTC core generates
> + binary signal with user-programmable low and high periods. Clock source for the
> + PWM can be either system clockor external clock. Each PWM timer block provides 8
> + PWM channels.
> +
> +allOf:
> + - $ref: pwm.yaml#
> +
> +properties:
> + compatible:
> + items:
Drop items, not a list in your case.
> + - const: starfive,jh7110-pwm
> +
Best regards,
Krzysztof
Powered by blists - more mailing lists