linux-kernel - Re: [PATCH v7 1/4] tools/nolibc: add stdint.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85e5fe90-4ff9-45f5-99d4-08ee737dfb51@t-8ch.de>
Date:   Tue, 28 Feb 2023 02:24:15 +0000
From:   Thomas Weißschuh <linux@...ssschuh.net>
To:     Vincent Dagonneau <v@....io>
Cc:     linux-kernel@...r.kernel.org, w@....eu
Subject: Re: [PATCH v7 1/4] tools/nolibc: add stdint.h

On Mon, Feb 27, 2023 at 09:11:33PM -0500, Vincent Dagonneau wrote:
> Nolibc works fine for small and limited program however most program
> expect integer types to be defined in stdint.h rather than std.h.
> 
> This is a quick fix that moves the existing integer definitions in std.h
> to stdint.h.
> 
> Signed-off-by: Vincent Dagonneau <v@....io>
> Signed-off-by: Willy Tarreau <w@....eu>
> Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net>

One more nitpick (applies to all patches):

The correct order of trailers would be:

Signed-off-by: Willy Tarreau <w@....eu>
Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net>
Signed-off-by: Vincent Dagonneau <v@....io>

In chronological order.

First Willy submitted something, then I reviewed it and then you
submitted it.
Your previous submissions/Signed-off-by are superseeded by the last one.

See Documentation/process/submitting-patches.rst.
(Especially search for "chronological")

Willy can probably fix this up when applying the series, so a new
revision may not be necessary.

> ---
>  tools/include/nolibc/Makefile |  4 ++--
>  tools/include/nolibc/std.h    | 15 +--------------
>  tools/include/nolibc/stdint.h | 24 ++++++++++++++++++++++++
>  3 files changed, 27 insertions(+), 16 deletions(-)
>  create mode 100644 tools/include/nolibc/stdint.h