linux-kernel - RE: [PATCH 05/20] lib: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB50892FA526AADBCA960D05B9D6AC9@CO1PR11MB5089.namprd11.prod.outlook.com>
Date:   Tue, 28 Feb 2023 16:35:27 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Nick Alcock <nick.alcock@...cle.com>,
        "mcgrof@...nel.org" <mcgrof@...nel.org>
CC:     "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Hitomi Hasegawa" <hasegawa-hitomi@...itsu.com>
Subject: RE: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules



> -----Original Message-----
> From: Nick Alcock <nick.alcock@...cle.com>
> Sent: Tuesday, February 28, 2023 5:02 AM
> To: mcgrof@...nel.org
> Cc: linux-modules@...r.kernel.org; linux-kernel@...r.kernel.org; Hitomi
> Hasegawa <hasegawa-hitomi@...itsu.com>; Keller, Jacob E
> <jacob.e.keller@...el.com>
> Subject: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules
> 
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> Cc: Jacob Keller <jacob.e.keller@...el.com>

Acked-by: Jacob Keller <jacob.e.keller@...el.com>

> ---
>  lib/pldmfw/pldmfw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c
> index 6e77eb6d8e72e..54e1809a38fd9 100644
> --- a/lib/pldmfw/pldmfw.c
> +++ b/lib/pldmfw/pldmfw.c
> @@ -875,5 +875,4 @@ int pldmfw_flash_image(struct pldmfw *context, const
> struct firmware *fw)
>  EXPORT_SYMBOL(pldmfw_flash_image);
> 
>  MODULE_AUTHOR("Jacob Keller <jacob.e.keller@...el.com>");
> -MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("PLDM firmware flash update library");
> --
> 2.39.1.268.g9de2f9a303