linux-kernel - Re: [PATCH 12/20] clk: microchip: mpfs: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2023 19:19:32 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Nick Alcock <nick.alcock@...cle.com>
Cc:     mcgrof@...nel.org, linux-modules@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in
 non-modules

On Tue, Feb 28, 2023 at 01:02:07PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> Cc: Conor Dooley <conor.dooley@...rochip.com>
> Cc: Daire McNamara <daire.mcnamara@...rochip.com>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: linux-riscv@...ts.infradead.org
> Cc: linux-clk@...r.kernel.org
> ---
>  drivers/clk/microchip/clk-mpfs.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk-mpfs.c
> index 4f0a19db7ed74..d85b345f4c08d 100644
> --- a/drivers/clk/microchip/clk-mpfs.c
> +++ b/drivers/clk/microchip/clk-mpfs.c
> @@ -513,4 +513,3 @@ MODULE_DESCRIPTION("Microchip PolarFire SoC Clock Driver");
>  MODULE_AUTHOR("Padmarao Begari <padmarao.begari@...rochip.com>");
>  MODULE_AUTHOR("Daire McNamara <daire.mcnamara@...rochip.com>");
>  MODULE_AUTHOR("Conor Dooley <conor.dooley@...rochip.com>");
> -MODULE_LICENSE("GPL");

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

I'll take this via the microchip/at91 clock tree after v6.3-rc1 has been
released.

Thanks,
Conor.


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)