linux-kernel - Re: [PATCHv3 2/4] wiegand: add Wiegand bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202303020615.0F00suDa-lkp@intel.com>
Date:   Thu, 2 Mar 2023 06:53:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Martin Zaťovič <m.zatovic1@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, gregkh@...uxfoundation.org,
        airlied@...hat.com, dipenp@...dia.com, treding@...dia.com,
        mwen@...lia.com, fmdefrancesco@...il.com, arnd@...db.de,
        bvanassche@....org, ogabbay@...nel.org, axboe@...nel.dk,
        mathieu.poirier@...aro.org, linux@...y.sk, masahiroy@...nel.org,
        yangyicong@...ilicon.com, dan.j.williams@...el.com,
        jacek.lawrynowicz@...ux.intel.com, benjamin.tissoires@...hat.com,
        devicetree@...r.kernel.org, furong.zhou@...ux.intel.com,
        andriy.shevchenko@...el.com, linus.walleij@...aro.org,
        Martin Zaťovič <m.zatovic1@...il.com>
Subject: Re: [PATCHv3 2/4] wiegand: add Wiegand bus driver

Hi Martin,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.2 next-20230301]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Martin-Za-ovi/dt-bindings-wiegand-add-Wiegand-controller-common-properties/20230301-223030
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230301142835.19614-3-m.zatovic1%40gmail.com
patch subject: [PATCHv3 2/4] wiegand: add Wiegand bus driver
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230302/202303020615.0F00suDa-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/c62b833f42989e355d82cd20b7803e0228e33792
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Martin-Za-ovi/dt-bindings-wiegand-add-Wiegand-controller-common-properties/20230301-223030
        git checkout c62b833f42989e355d82cd20b7803e0228e33792
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/wiegand/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303020615.0F00suDa-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/wiegand/wiegand.c:441:27: error: initialization of 'void (*)(struct device *)' from incompatible pointer type 'int (*)(struct device *)' [-Werror=incompatible-pointer-types]
     441 |         .remove         = wiegand_remove,
         |                           ^~~~~~~~~~~~~~
   drivers/wiegand/wiegand.c:441:27: note: (near initialization for 'wiegand_bus_type.remove')
   cc1: some warnings being treated as errors


vim +441 drivers/wiegand/wiegand.c

   436	
   437	static struct bus_type wiegand_bus_type = {
   438		.name		= "wiegand",
   439		.match		= wiegand_match_device,
   440		.probe		= wiegand_probe,
 > 441		.remove		= wiegand_remove,
   442	};
   443	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests