linux-kernel - Re: [PATCH v3] ACPI: cpufreq: use a platform device to load ACPI PPC and PCC drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2023 07:48:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Petr Pavlu <petr.pavlu@...e.com>, rafael@...nel.org,
        lenb@...nel.org, viresh.kumar@...aro.org
Cc:     oe-kbuild-all@...ts.linux.dev, pmladek@...e.com, mcgrof@...nel.org,
        linux-acpi@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Petr Pavlu <petr.pavlu@...e.com>
Subject: Re: [PATCH v3] ACPI: cpufreq: use a platform device to load ACPI PPC
 and PCC drivers

Hi Petr,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master v6.2 next-20230301]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Petr-Pavlu/ACPI-cpufreq-use-a-platform-device-to-load-ACPI-PPC-and-PCC-drivers/20230301-165927
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20230301085717.10411-1-petr.pavlu%40suse.com
patch subject: [PATCH v3] ACPI: cpufreq: use a platform device to load ACPI PPC and PCC drivers
config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20230302/202303020759.pwVPib0p-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/59eb26f9b02165cc5c5fb6514ff4d2a8d7a91356
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Petr-Pavlu/ACPI-cpufreq-use-a-platform-device-to-load-ACPI-PPC-and-PCC-drivers/20230301-165927
        git checkout 59eb26f9b02165cc5c5fb6514ff4d2a8d7a91356
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303020759.pwVPib0p-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/acpi/acpi_processor.c:177:13: warning: no previous prototype for 'acpi_pcc_cpufreq_init' [-Wmissing-prototypes]
     177 | void __init acpi_pcc_cpufreq_init(void) {}
         |             ^~~~~~~~~~~~~~~~~~~~~


vim +/acpi_pcc_cpufreq_init +177 drivers/acpi/acpi_processor.c

   162	
   163	#ifdef CONFIG_X86
   164	/* Check presence of Processor Clocking Control by searching for \_SB.PCCH. */
   165	void __init acpi_pcc_cpufreq_init(void)
   166	{
   167		acpi_status status;
   168		acpi_handle handle;
   169	
   170		status = acpi_get_handle(NULL, "\\_SB", &handle);
   171		if (ACPI_FAILURE(status))
   172			return;
   173		if (acpi_has_method(handle, "PCCH"))
   174			cpufreq_add_device("pcc-cpufreq");
   175	}
   176	#else
 > 177	void __init acpi_pcc_cpufreq_init(void) {}
   178	#endif /* CONFIG_X86 */
   179	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests