linux-kernel - RE: [EXT] Re: [PATCH 4/6] PM: domains: Export genpd_dev_pm_attach_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <GV1PR04MB91839451082E48FA8C3BD48AFBAD9@GV1PR04MB9183.eurprd04.prod.outlook.com>
Date:   Wed, 1 Mar 2023 03:00:22 +0000
From:   "J.D. Yue" <jindong.yue@....com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     "rafael@...nel.org" <rafael@...nel.org>,
        "khilman@...nel.org" <khilman@...nel.org>,
        "pavel@....cz" <pavel@....cz>,
        "len.brown@...el.com" <len.brown@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        Peng Fan <peng.fan@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH 4/6] PM: domains: Export
 genpd_dev_pm_attach_by_name()


> -----Original Message-----
> From: Ulf Hansson <ulf.hansson@...aro.org>
> Sent: Tuesday, February 28, 2023 6:28 PM
> To: J.D. Yue <jindong.yue@....com>
> Cc: rafael@...nel.org; khilman@...nel.org; pavel@....cz;
> len.brown@...el.com; gregkh@...uxfoundation.org; shawnguo@...nel.org;
> s.hauer@...gutronix.de; Peng Fan <peng.fan@....com>;
> linux-pm@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [EXT] Re: [PATCH 4/6] PM: domains: Export
> genpd_dev_pm_attach_by_name()
> 
> Caution: EXT Email
> 
> On Tue, 28 Feb 2023 at 08:59, Jindong Yue <jindong.yue@....com> wrote:
> >
> > The genpd_dev_pm_attach_by_name() allows a device to be associated
> > with its PM domain by name.
> >
> > Export it for use by kernel modules, such as the i.MX8M blk-ctrl drivers:
> > imx8m-blk-ctrl and imx8mp-blk-ctrl.
> 
> The genpd_dev_pm_attach_by_*() are not intended to be used by any
> consumer drivers at all. Instead, please use
> dev_pm_domain_attach_by_*() instead.

Thanks, I just tested dev_pm_domain_attach_by_*() works for me. I will drop this patch and fix it in driver.

> 
> >
> > Signed-off-by: Jindong Yue <jindong.yue@....com>
> > ---
> >  drivers/base/power/domain.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> > index 32084e38b73d..6d66b6b14863 100644
> > --- a/drivers/base/power/domain.c
> > +++ b/drivers/base/power/domain.c
> > @@ -2908,6 +2908,7 @@ struct device
> > *genpd_dev_pm_attach_by_name(struct device *dev, const char *name)
> >
> >         return genpd_dev_pm_attach_by_id(dev, index);  }
> > +EXPORT_SYMBOL_GPL(genpd_dev_pm_attach_by_name);
> >
> >  static const struct of_device_id idle_state_match[] = {
> >         { .compatible = "domain-idle-state", },
> > --
> > 2.36.0
> >
> 
> Kind regards
> Uffe

BRs,
Jindong