linux-kernel - Re: [PATCH net-next v3 01/10] net: wwan: tmi: Add PCIe core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Mar 2023 03:35:05 +0000
From:   Yanchao Yang (杨彦超) 
        <Yanchao.Yang@...iatek.com>
To:     "pabeni@...hat.com" <pabeni@...hat.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "loic.poulain@...aro.org" <loic.poulain@...aro.org>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>
CC:     Chris Feng (冯保林) 
        <Chris.Feng@...iatek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mingliang Xu (徐明亮) 
        <mingliang.xu@...iatek.com>,
        Min Dong (董敏) <min.dong@...iatek.com>,
        "linuxwwan@...el.com" <linuxwwan@...el.com>,
        "m.chetan.kumar@...el.com" <m.chetan.kumar@...el.com>,
        Liang Lu (吕亮) <liang.lu@...iatek.com>,
        Haijun Liu (刘海军) 
        <haijun.liu@...iatek.com>,
        Haozhe Chang (常浩哲) 
        <Haozhe.Chang@...iatek.com>,
        Hua Yang (杨华) <Hua.Yang@...iatek.com>,
        "Xiayu.Zhang@...i" <Xiayu.Zhang@...i>,
        "ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>
Subject: Re: [PATCH net-next v3 01/10] net: wwan: tmi: Add PCIe core

On Tue, 2023-02-28 at 10:31 -0800, Jakub Kicinski wrote:
> On Tue, 28 Feb 2023 07:47:09 +0000 Yanchao Yang (杨彦超) wrote:
> > 1. We receive many comments at the beginning of several patches.
> > There
> > are little comments about other patches. How about other patches
> > (patch
> > 2~patch 10)? 
> 
> It's because patches are too long, so reviewers are unlikely to
> allocate sufficiently long block of time to look thru all of 
> the code in one sitting.
> 
Get it. It’s hard to review the whole patches in one sitting. So V3 has
been reduced 4k+ lines compared with V2 according to your suggestion.
Do you have any suggestions on that should we wait for feedback on
other patches or what we can do to help reviewers to review patches
more smoothly?
BTW, the patches are reviewed one by one (patch1, patch2, ….), or are
controlled by reviewers (there is no obvious order for reviewing the
patch)?

> > 2. Need we add your name in the tag “Reviewed-by: “ next version?
> 
> No, no, don't put review tags on patches unless explicitly asked to.
Get it.

Many thanks.