linux-kernel - Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable bcntime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/8rUTtuzcgp34KQ@corigine.com>
Date:   Wed, 1 Mar 2023 11:39:13 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Ping-Ke Shih <pkshih@...ltek.com>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable
 bcntime_cfg

On Wed, Mar 01, 2023 at 12:32:38AM +0000, Ping-Ke Shih wrote:
> 
> 
> > -----Original Message-----
> > From: Simon Horman <simon.horman@...igine.com>
> > Sent: Tuesday, February 28, 2023 7:07 PM
> > To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> > Cc: Ping-Ke Shih <pkshih@...ltek.com>; kvalo@...nel.org; davem@...emloft.net; edumazet@...gle.com;
> > kuba@...nel.org; pabeni@...hat.com; linux-wireless@...r.kernel.org; netdev@...r.kernel.org;
> > linux-kernel@...r.kernel.org; Abaci Robot <abaci@...ux.alibaba.com>
> > Subject: Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable bcntime_cfg
> > 
> > On Tue, Feb 28, 2023 at 10:11:32AM +0800, Jiapeng Chong wrote:
> > > Variable bcntime_cfg is not effectively used, so delete it.
> > >
> > > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:6: warning: variable 'bcntime_cfg' set but not
> > used.
> > >
> > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4240
> > > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> > 
> > Hi Jiapeng Chong,
> > 
> > this looks good to me.
> > 
> > Reviewed-by: Simon Horman <simon.horman@...igine.com>
> > 
> > While reviewing this gcc 12.2.0 told me:
> > 
> > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:25: error: unused variable 'bcn_ifs'
> > [-Werror=unused-variable]
> >  1555 |         u16 bcn_cw = 6, bcn_ifs = 0xf;
> >       |                         ^~~~~~~
> > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:13: error: unused variable 'bcn_cw'
> > [-Werror=unused-variable]
> >  1555 |         u16 bcn_cw = 6, bcn_ifs = 0xf;
> >       |             ^~~~~~
> > 
> > So perhaps you could consider sending another patch to remove them too.
> > 
> 
> These errors are introduced by this patch, so please fix them together by this
> patch.

Yes, indeed. Sorry for missing that important point.
Had I noticed it my advice would have been the same as yours.