linux-kernel - Re: [PATCH] ASoC: mediatek: add missing initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Mar 2023 10:37:12 +0000
From:   Trevor Wu (吳文良) <Trevor.Wu@...iatek.com>
To:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "perex@...ex.cz" <perex@...ex.cz>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH] ASoC: mediatek: add missing initialization

On Wed, 2023-03-01 at 11:00 +0100, AngeloGioacchino Del Regno wrote:
> Il 01/03/23 05:08, Trevor Wu ha scritto:
> > In etdm dai driver, dai_etdm_parse_of() function is used to parse
> > dts
> > properties to get parameters. There are two for-loops which are
> > sepearately for all etdm and etdm input only cases. In etdm in only
> > loop, dai_id is not initialized, so it keeps the value intiliazed
> > in
> > another loop.
> > 
> > In the patch, add the missing initialization to fix the unexpected
> > parsing problem.
> > 
> > Signed-off-by: Trevor Wu <trevor.wu@...iatek.com>
> 
> I agree about this fix, but this commit is not fine as it is:
> Please split it in two commits and add the appropriate Fixes tag to
> each
> for backports.
> 
> Regards,
> Angelo
> 

Got it.
I will split it into two commits in V2.

Thanks,
Trevor