linux-kernel - Re: [PATCH v2 2/5] dma-mapping: Provide a fallback dma_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230301130315.GA467@lst.de>
Date:   Wed, 1 Mar 2023 14:03:15 +0100
From:   Christoph Hellwig <hch@....de>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, tsbogend@...ha.franken.de,
        mpe@...erman.id.au, paul.walmsley@...ive.com, palmer@...belt.com,
        robh+dt@...nel.org, hch@....de, m.szyprowski@...sung.com,
        robin.murphy@....com, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 2/5] dma-mapping: Provide a fallback
 dma_default_coherent

On Thu, Feb 23, 2023 at 11:36:41AM +0000, Jiaxun Yang wrote:
> dma_default_coherent was decleared unconditionally at kernel/dma/mapping.c
> but only decleared when any of non-coherent options is enabled in dma-map-ops.h.

Overly lone line here.

>  }
>  #else
> +#define dma_default_coherent true
>  static inline bool dev_is_dma_coherent(struct device *dev)

Please keep an empty line before the function declaration.