linux-kernel - Re: [PATCH v3] ASoC: cs35l41: Steam Deck Shared boost properties quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <099945bb-8da6-7a47-5dff-6a1a457fbf7d@collabora.com>
Date:   Wed, 1 Mar 2023 16:14:05 +0000
From:   Lucas Tanure <lucas.tanure@...labora.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     David Rhodes <david.rhodes@...rus.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        "Takashi Iwai --cc=alsa-devel @ alsa-project . org" <tiwai@...e.com>,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH v3] ASoC: cs35l41: Steam Deck Shared boost properties
 quirk

On 01-03-2023 14:50, Mark Brown wrote:
> On Wed, Mar 01, 2023 at 12:44:47PM +0000, Lucas Tanure wrote:
>> Add support for Steam Deck bios old properties. If a Steam deck didn't
>> upgrade the BIOS, the driver should be able to handle the previous
>> properties for shared boost types.
> 
> This doesn't build:
> 
> /build/stage/linux/sound/soc/codecs/cs35l41.c: In function ‘cs35l41_handle_pdata’:
> /build/stage/linux/sound/soc/codecs/cs35l41.c:1041:36: error: ‘CS35L41_SHD_BOOST_ACTV’ undeclared (first use in this function); did you mean ‘CS35L41_EXT_BOOST’?
>   1041 |                 hw_cfg->bst_type = CS35L41_SHD_BOOST_ACTV;
>        |                                    ^~~~~~~~~~~~~~~~~~~~~~
>        |                                    CS35L41_EXT_BOOST
> /build/stage/linux/sound/soc/codecs/cs35l41.c:1041:36: note: each undeclared identifier is reported only once for each function it appears in
> /build/stage/linux/sound/soc/codecs/cs35l41.c:1043:36: error: ‘CS35L41_SHD_BOOST_PASS’ undeclared (first use in this function); did you mean ‘CS35L41_EXT_BOOST’?
>   1043 |                 hw_cfg->bst_type = CS35L41_SHD_BOOST_PASS;
>        |                                    ^~~~~~~~~~~~~~~~~~~~~~
>        |                                    CS35L41_EXT_BOOST
> 
My mistake, it seems I checkout the wrong tree here with the Shared 
boost patches already merged.
This patches needed the previous Shared boost series merged.
I will wait for that patches series to be merged.
Sorry About that.