linux-kernel - Re: [RFC PATCH] irqchip/gic-v3: Claim iomem resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86k000l9so.wl-maz@kernel.org>
Date:   Wed, 01 Mar 2023 16:24:07 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Robin Murphy <robin.murphy@....com>
Cc:     Tim Harvey <tharvey@...eworks.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Al Cooper <alcooperx@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>, tglx@...utronix.de,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] irqchip/gic-v3: Claim iomem resources

On Wed, 01 Mar 2023 16:12:58 +0000,
Robin Murphy <robin.murphy@....com> wrote:
> 
> On 2023-02-28 23:22, Marc Zyngier wrote:
> > On Tue, 28 Feb 2023 23:11:15 +0000,
> > Tim Harvey <tharvey@...eworks.com> wrote:
> >> 
> >> I have bisected a kernel issue where octeontx (CN803x) will hang on
> >> reboot caused by commit c0db06fd0993 ("mmc: core: Disable card detect
> >> during shutdown"). This commit made it into 5.16 and stable kernels.
> >> I've found that the patch here which is commit 2b2cd74a06c3 resolves
> >> this hang but I'm not entirely clear why.
> >> 
> >> Does anyone have a good explanation of why the hang occurs in the
> >> first place and why this resolves it? I would like to get the proper
> >> fix into the affected stable branches.
> > 
> > Wild guess: the reservation prevents some other driver from probing
> > because the firmware describes overlapping ranges, and that driver is
> > what is causing your above hang.
> 
> Indeed, according to [1], the GIC appears to overlap one of the "PCIe"
> windows of &ecam0, which conveniently appears to be the parent of the
> MMC controller as well.

Huh, quality firmware. So clearly nothing to backport. Just a DT
update to distribute... :-/

	M.

-- 
Without deviation from the norm, progress is not possible.