linux-kernel - Re: [PATCH] spi: spi-sn-f-ospi: fix white spaces and improve code formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 1 Mar 2023 18:21:26 +0000
From:   Mark Brown <broonie@...nel.org>
To:     dhruva gole <d-gole@...com>
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Pratyush Yadav <ptyadav@...zon.de>, linux-spi@...r.kernel.org,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: spi-sn-f-ospi: fix white spaces and improve code
 formatting

On Wed, Mar 01, 2023 at 10:49:31AM +0530, dhruva gole wrote:
> On 27/02/23 19:39, Mark Brown wrote:
> > On Thu, Feb 23, 2023 at 03:59:18PM +0530, Dhruva Gole wrote:

> > > Allignment issues in all the macro definitions of this driver have been
> > > fixed for better asthetics

> > In what way?

> In my humble opinion, the spacing between the MACRO names

> and their values seemed a bit OFF. Like there lacked

> consistency for example:

> OSPI_PROT_MODE_QUAD			2
> OSPI_PROT_MODE_OCTAL		3

> Here we can see 3 is at a shorter length compared to 2 from their respective macros.

These look perfectly lined up for me.  I suspect you may have your tab
size set to something other than 8.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)