linux-kernel - Re: [PATCH AUTOSEL 6.2 2/6] efi: efivars: prevent double registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/+gfKHBuub3IxIb@sashalap>
Date:   Wed, 1 Mar 2023 13:59:08 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Ard Biesheuvel <ardb@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Johan Hovold <johan+linaro@...nel.org>,
        linux-efi@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.2 2/6] efi: efivars: prevent double registration

On Wed, Mar 01, 2023 at 05:31:15PM +0100, Ard Biesheuvel wrote:
>On Wed, 1 Mar 2023 at 17:29, Sasha Levin <sashal@...nel.org> wrote:
>>
>> From: Johan Hovold <johan+linaro@...nel.org>
>>
>> [ Upstream commit 0217a40d7ba6e71d7f3422fbe89b436e8ee7ece7 ]
>>
>> Add the missing sanity check to efivars_register() so that it is no
>> longer possible to override an already registered set of efivar ops
>> (without first deregistering them).
>>
>> This can help debug initialisation ordering issues where drivers have so
>> far unknowingly been relying on overriding the generic ops.
>>
>> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
>> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>NAK this is not a bugfix.

Ack, I'll drop it. Thanks!

-- 
Thanks,
Sasha