linux-kernel - Re: [PATCH v5 1/2] fs/proc: optimize register ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7B4C8B8B94D621CB+fbf73a3a-6a10-5fbc-e5e5-87e2f56f6878@uniontech.com>
Date:   Thu, 2 Mar 2023 10:56:10 +0800
From:   Meng Tang <tangmeng@...ontech.com>
To:     Luis Chamberlain <mcgrof@...nel.org>,
        Peng Zhang <zhangpeng362@...wei.com>,
        Joel Granados <j.granados@...sung.com>
Cc:     keescook@...omium.org, yzaikin@...gle.com, ebiederm@...ssion.com,
        willy@...radead.org, kbuild-all@...ts.01.org,
        nixiaoming@...wei.com, nizhen@...ontech.com,
        sujiaxun@...ontech.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] fs/proc: optimize register ctl_tables



On 2023/3/2 09:12, Luis Chamberlain wrote:

> That would solve the first part -- the fragile odd checks to bail out
> early.  But not the odd accounting we have to do at times. So it begs
> the question if we can instead deprecate register_sysctl_table() and
> then have a counter for us at all times. Also maybe an even simpler
> alternative may just be to see to have the nr_entries be inferred with
> ARRAY_SIZE() if count_subheaders() == 1? I haven't looked into that yet.
> 
>    Luis
> 
The current difficulty is to get the ARRAY_SIZE() of table->child table.

It would be great if have a better way to solve this problem.

      Meng