linux-kernel - Re: [PATCH v3 2/2] vfs: avoid duplicating creds in faccessat if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAEC3LN6oUe6BKSN@ZenIV>
Date:   Thu, 2 Mar 2023 20:11:08 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Kees Cook <keescook@...omium.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Mateusz Guzik <mjguzik@...il.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Christian Brauner <brauner@...nel.org>, serge@...lyn.com,
        paul@...l-moore.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH v3 2/2] vfs: avoid duplicating creds in faccessat if
 possible

On Thu, Mar 02, 2023 at 11:54:03AM -0800, Kees Cook wrote:
> On Thu, Mar 02, 2023 at 07:19:49PM +0000, Al Viro wrote:
> > On Thu, Mar 02, 2023 at 11:10:03AM -0800, Linus Torvalds wrote:
> > > On Thu, Mar 2, 2023 at 11:03 AM Linus Torvalds
> > > <torvalds@...ux-foundation.org> wrote:
> > > >
> > > > It might be best if we actually exposed it as a SLAB_SKIP_ZERO thing,
> > > > just to make it possible to say - exactly in situations like this -
> > > > that this particular slab cache has no advantage from pre-zeroing.
> > > 
> > > Actually, maybe it's just as well to keep it per-allocation, and just
> > > special-case getname_flags() itself.
> > > 
> > > We could replace the __getname() there with just a
> > > 
> > >         kmem_cache_alloc(names_cachep, GFP_KERNEL | __GFP_SKIP_ZERO);
> > > 
> > > we're going to overwrite the beginning of the buffer with the path we
> > > copy from user space, and then we'd have to make people comfortable
> > > with the fact that even with zero initialization hardening on, the
> > > space after the filename wouldn't be initialized...
> > 
> > ACK; same in getname_kernel() and sys_getcwd(), at the very least.
> 
> FWIW, much earlier analysis suggested opting out these kmem caches:
> 
> 	buffer_head
> 	names_cache
> 	mm_struct
> 	anon_vma
> 	skbuff_head_cache
> 	skbuff_fclone_cache

I would probably add dentry_cache to it; the only subtle part is
->d_iname and I'm convinced that explicit "make sure there's a NUL
at the very end" is enough.