linux-kernel - Re: [PATCH v2] perf: arm_cspmu: Fix variable dereference warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2023 13:02:39 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Besar Wicaksono <bwicaksono@...dia.com>, suzuki.poulose@....com,
        catalin.marinas@....com, will@...nel.org, mark.rutland@....com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, treding@...dia.com,
        jonathanh@...dia.com, vsethi@...dia.com
Subject: Re: [PATCH v2] perf: arm_cspmu: Fix variable dereference warning



On 3/2/23 12:57, Besar Wicaksono wrote:
> Fix warning message from smatch tool:
>   | smatch warnings:
>   | drivers/perf/arm_cspmu/arm_cspmu.c:1075 arm_cspmu_find_cpu_container()
>   |    warn: variable dereferenced before check 'cpu_dev' (see line 1073)
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <error27@...il.com>
> Link: https://lore.kernel.org/r/202302191227.kc0V8fM7-lkp@intel.com/
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>
> Signed-off-by: Besar Wicaksono <bwicaksono@...dia.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
> 
> Changes from v1:
>  * Update commit subject and description
>  * Added Reviewed-by from Suzuki
> v1: https://lore.kernel.org/linux-arm-kernel/20230301225657.30211-1-bwicaksono@nvidia.com/T/#u
> 
> ---
>  drivers/perf/arm_cspmu/arm_cspmu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
> index e31302ab7e37..a3f1c410b417 100644
> --- a/drivers/perf/arm_cspmu/arm_cspmu.c
> +++ b/drivers/perf/arm_cspmu/arm_cspmu.c
> @@ -1078,12 +1078,14 @@ static int arm_cspmu_request_irq(struct arm_cspmu *cspmu)
>  static inline int arm_cspmu_find_cpu_container(int cpu, u32 container_uid)
>  {
>  	u32 acpi_uid;
> -	struct device *cpu_dev = get_cpu_device(cpu);
> -	struct acpi_device *acpi_dev = ACPI_COMPANION(cpu_dev);
> +	struct device *cpu_dev;
> +	struct acpi_device *acpi_dev;
>  
> +	cpu_dev = get_cpu_device(cpu);
>  	if (!cpu_dev)
>  		return -ENODEV;
>  
> +	acpi_dev = ACPI_COMPANION(cpu_dev);
>  	while (acpi_dev) {
>  		if (!strcmp(acpi_device_hid(acpi_dev),
>  			    ACPI_PROCESSOR_CONTAINER_HID) &&
> 
> base-commit: 7f7a8831520f12a3cf894b0627641fad33971221

-- 
~Randy