| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAM9d7chQA27aD_mPe=3-9jZLWP_a64ztihuK=upgNL++kMFSNw@mail.gmail.com>
Date: Thu, 2 Mar 2023 14:12:29 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Ravi Bangoria <ravi.bangoria@....com>
Cc: peterz@...radead.org, eranian@...gle.com, acme@...nel.org,
mark.rutland@....com, jolsa@...nel.org, irogers@...gle.com,
bp@...en8.de, x86@...nel.org, linux-perf-users@...r.kernel.org,
linux-kernel@...r.kernel.org, sandipan.das@....com,
ananth.narayan@....com, santosh.shukla@....com
Subject: Re: [PATCH 2/2] perf test: Add selftest to test IBS invocation via
core pmu events
On Thu, Mar 2, 2023 at 1:22 AM Ravi Bangoria <ravi.bangoria@....com> wrote:
>
> IBS pmu can be invoked via fixed set of core pmu events. Add simple
> event open test for all these events.
>
> Without kernel fix:
> $ sudo ./perf test -vv 76
> 76: IBS via core pmu :
> --- start ---
> test child forked, pid 6553
> Using CPUID AuthenticAMD-25-1-1
> type: 0x0, config: 0x0, fd: 3 - Pass
> type: 0x0, config: 0x1, fd: -1 - Pass
> type: 0x4, config: 0x76, fd: -1 - Fail
> type: 0x4, config: 0xc1, fd: -1 - Fail
> type: 0x4, config: 0x12, fd: -1 - Pass
> test child finished with -1
> ---- end ----
> IBS via core pmu: FAILED!
>
> With kernel fix:
> $ sudo ./perf test -vv 76
> 76: IBS via core pmu :
> --- start ---
> test child forked, pid 7526
> Using CPUID AuthenticAMD-25-1-1
> type: 0x0, config: 0x0, fd: 3 - Pass
> type: 0x0, config: 0x1, fd: -1 - Pass
> type: 0x4, config: 0x76, fd: 3 - Pass
> type: 0x4, config: 0xc1, fd: 3 - Pass
> type: 0x4, config: 0x12, fd: -1 - Pass
> test child finished with 0
> ---- end ----
> IBS via core pmu: Ok
>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@....com>
> ---
> tools/perf/tests/Build | 1 +
> tools/perf/tests/builtin-test.c | 1 +
> tools/perf/tests/ibs-via-core-pmu.c | 70 +++++++++++++++++++++++++++++
> tools/perf/tests/tests.h | 1 +
> 4 files changed, 73 insertions(+)
> create mode 100644 tools/perf/tests/ibs-via-core-pmu.c
>
> diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
> index fb9ac5dc4079..1a232cf13c33 100644
> --- a/tools/perf/tests/Build
> +++ b/tools/perf/tests/Build
> @@ -69,6 +69,7 @@ perf-y += dlfilter-test.o
> perf-y += sigtrap.o
> perf-y += event_groups.o
> perf-y += symbols.o
> +perf-y += ibs-via-core-pmu.o
>
> $(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build
> $(call rule_mkdir)
> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 35cc3807cc9e..aed887234500 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -119,6 +119,7 @@ static struct test_suite *generic_tests[] = {
> &suite__sigtrap,
> &suite__event_groups,
> &suite__symbols,
> + &suite__ibs_via_core_pmu,
> NULL,
> };
>
> diff --git a/tools/perf/tests/ibs-via-core-pmu.c b/tools/perf/tests/ibs-via-core-pmu.c
> new file mode 100644
> index 000000000000..6ac539509791
> --- /dev/null
> +++ b/tools/perf/tests/ibs-via-core-pmu.c
> @@ -0,0 +1,70 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include "linux/perf_event.h"
> +#include "tests.h"
> +#include "pmu.h"
> +#include "pmus.h"
> +#include "../perf-sys.h"
> +#include "debug.h"
> +
> +#define NR_SUB_TESTS 5
> +
> +static struct sub_tests {
> + int type;
> + unsigned long config;
> + bool valid;
> +} sub_tests[NR_SUB_TESTS] = {
> + { PERF_TYPE_HARDWARE, PERF_COUNT_HW_CPU_CYCLES, true },
> + { PERF_TYPE_HARDWARE, PERF_COUNT_HW_INSTRUCTIONS, false },
> + { PERF_TYPE_RAW, 0x076, true },
> + { PERF_TYPE_RAW, 0x0C1, true },
> + { PERF_TYPE_RAW, 0x012, false },
> +};
> +
> +static int event_open(int type, unsigned long config)
> +{
> + struct perf_event_attr attr;
> +
> + memset(&attr, 0, sizeof(struct perf_event_attr));
> + attr.type = type;
> + attr.size = sizeof(struct perf_event_attr);
> + attr.config = config;
> + attr.disabled = 1;
> + attr.precise_ip = 1;
> + attr.sample_type = PERF_SAMPLE_IP | PERF_SAMPLE_TID;
> + attr.sample_period = 100000;
> +
> + return sys_perf_event_open(&attr, -1, 0, -1, 0);
> +}
> +
> +static int test__ibs_via_core_pmu(struct test_suite *text __maybe_unused,
> + int subtest __maybe_unused)
> +{
> + struct perf_pmu *ibs_pmu;
> + int ret = TEST_OK;
> + int fd, i;
> +
> + if (list_empty(&pmus))
> + perf_pmu__scan(NULL);
> +
> + ibs_pmu = perf_pmu__find("ibs_op");
> + if (!ibs_pmu)
> + return TEST_SKIP;
> +
> + for (i = 0; i < NR_SUB_TESTS; i++) {
> + fd = event_open(sub_tests[i].type, sub_tests[i].config);
> + pr_debug("type: 0x%x, config: 0x%lx, fd: %d - ", sub_tests[i].type,
> + sub_tests[i].config, fd);
> + if ((sub_tests[i].valid && fd == -1) ||
> + (!sub_tests[i].valid && fd > 0)) {
> + pr_debug("Fail\n");
> + ret = TEST_FAIL;
You need to close(fd) when it's succeeded for invalid one.
Thanks,
Namhyung
> + } else {
> + pr_debug("Pass\n");
> + close(fd);
> + }
> + }
> +
> + return ret;
> +}
> +
> +DEFINE_SUITE("IBS via core pmu", ibs_via_core_pmu);
> diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
> index 9a0f3904e53d..36339fdf9c36 100644
> --- a/tools/perf/tests/tests.h
> +++ b/tools/perf/tests/tests.h
> @@ -149,6 +149,7 @@ DECLARE_SUITE(dlfilter);
> DECLARE_SUITE(sigtrap);
> DECLARE_SUITE(event_groups);
> DECLARE_SUITE(symbols);
> +DECLARE_SUITE(ibs_via_core_pmu);
>
> /*
> * PowerPC and S390 do not support creation of instruction breakpoints using the
> --
> 2.39.2
>
Powered by blists - more mailing lists