linux-kernel - Re: [PATCH] nodemask: Drop duplicate check in for_each_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZABKvSq9TQxxQnu7@yury-laptop>
Date:   Wed, 1 Mar 2023 23:05:33 -0800
From:   Yury Norov <yury.norov@...il.com>
To:     Gavin Shan <gshan@...hat.com>
Cc:     linux-kernel@...r.kernel.org, andriy.shevchenko@...ux.intel.com,
        linux@...musvillemoes.dk, shan.gavin@...il.com
Subject: Re: [PATCH] nodemask: Drop duplicate check in for_each_node_mask()

On Tue, Jan 24, 2023 at 08:02:43AM +0800, Gavin Shan wrote:
> The return value type is changed from 'int' to 'unsigned int' since
> commit 0dfe54071d7c8 ("nodemask: Fix return values to be unsigned").
> Besides, the conversion between 'int' and 'unsigned int' on the
> parameter @node is guaranteed to be safe due to the limited range of
> MAX_NUMNODES and CONFIG_NODES_SHIFT. By the way, '(node >= 0)' should
> have been '(node) >= 0' actually.
> 
> It's unnecessary to check if their return values are greater or equal
> to 0 in for_each_node_mask(). Remove it.
> 
> No functional change intended.
> 
> Signed-off-by: Gavin Shan <gshan@...hat.com>

Applied, thanks.