linux-kernel - Re: [PATCH v3 2/2] vfs: avoid duplicating creds in faccessat if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230302083025.khqdizrnjkzs2lt6@wittgenstein>
Date:   Thu, 2 Mar 2023 09:30:25 +0100
From:   Christian Brauner <brauner@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Mateusz Guzik <mjguzik@...il.com>, viro@...iv.linux.org.uk,
        serge@...lyn.com, paul@...l-moore.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org
Subject: Re: [PATCH v3 2/2] vfs: avoid duplicating creds in faccessat if
 possible

On Mon, Feb 27, 2023 at 04:44:06PM -0800, Linus Torvalds wrote:
> On Wed, Jan 25, 2023 at 7:56 AM Mateusz Guzik <mjguzik@...il.com> wrote:
> >
> > Turns out for typical consumers the resulting creds would be identical
> > and this can be checked upfront, avoiding the hard work.
> 
> I've applied this v3 of the two patches.
> 
> Normally it would go through Al, but he's clearly been under the
> weather and is drowning in email. Besides, I'm comfortable with this
> particular set of patches anyway as I was involved in the previous
> round of access() overhead avoidance with the whole RCU grace period
> thing.
> 
> So I think we're all better off having Al look at any iov_iter issues.
> 
> Anybody holler if there are issues,

Fwiw, as long as you, Al, and others are fine with it and I'm aware of
it I'm happy to pick up more stuff like this. I've done it before and
have worked in this area so I'm happy to help with some of the load.

Christian