linux-kernel - Re: [PATCH v2 1/3] leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230302093317.574c87a1@md1za8fc.ad001.siemens.net>
Date:   Thu, 2 Mar 2023 09:33:17 +0100
From:   Henning Schild <henning.schild@...mens.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2 1/3] leds: simatic-ipc-leds-gpio: move two extra gpio
 pins into another table

Am Wed, 1 Mar 2023 19:21:53 +0200
schrieb Andy Shevchenko <andriy.shevchenko@...ux.intel.com>:

> On Wed, Mar 01, 2023 at 06:02:13PM +0100, Henning Schild wrote:
> > There are two special pins needed to init the LEDs. We used to have
> > them at the end of the gpiod_lookup table to give to "leds-gpio". A
> > cleaner way is to have a dedicated table for the special pins.  
> 
> ...
> 
> > +	.dev_id = NULL,  
> 
> Technically speaking this is redundant. Maybe you wanted to be more
> explicit with a comment like
> 
> 	.dev_id = NULL,		/* Filled during
> initialization */
> 
> ...
> 
> > +	.dev_id = NULL,  
> 
> Ditto.

Sorry you already pointed that out earlier, it slipped back in with
the rewrite.

Henning