linux-kernel - Re: [PATCH] mm/migrate: Drop pte_mkhuge() in remove_migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39c91d34-9d77-8e63-388c-6893b40c31d9@redhat.com>
Date:   Thu, 2 Mar 2023 10:02:33 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Anshuman Khandual <anshuman.khandual@....com>, linux-mm@...ck.org
Cc:     mike.kravetz@...cle.com, Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH] mm/migrate: Drop pte_mkhuge() in remove_migration_pte()

On 02.03.23 03:53, Anshuman Khandual wrote:
> Since the following commit, arch_make_huge_pte() should be used directly in
> generic memory subsystem as a platform provided page table helper, instead
> of pte_mkhuge(). This just drops pte_mkhuge() from remove_migration_pte(),
> which has now become redundant.
> 
> 'commit 16785bd77431 ("mm: merge pte_mkhuge() call into arch_make_huge_pte()")'
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-mm@...ck.org
> Cc: linux-kernel@...r.kernel.org
> Reported-by: Christophe Leroy <christophe.leroy@...roup.eu>
> Link: https://lore.kernel.org/all/1ea45095-0926-a56a-a273-816709e9075e@csgroup.eu/
> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
> ---
> This applies on latest mainline.
> 
>   mm/migrate.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 37865f85df6d..d3964c414010 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -249,7 +249,6 @@ static bool remove_migration_pte(struct folio *folio,
>   		if (folio_test_hugetlb(folio)) {
>   			unsigned int shift = huge_page_shift(hstate_vma(vma));
>   
> -			pte = pte_mkhuge(pte);
>   			pte = arch_make_huge_pte(pte, shift, vma->vm_flags);
>   			if (folio_test_anon(folio))
>   				hugepage_add_anon_rmap(new, vma, pvmw.address,

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb